-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply foreground color to minor ticks #2305
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2305 +/- ##
=======================================
Coverage 88.06% 88.06%
=======================================
Files 247 247
Lines 23476 23476
=======================================
Hits 20673 20673
Misses 2803 2803
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -4,6 +4,8 @@ Full changelog | |||
v1.4.0 (2022-05-31) | |||
------------------- | |||
|
|||
* Fixed a bug where minor tick marks were not respecting the settings colors. [#2305] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this to 1.6.0? (I am going to work on a way to avoid us having to do this in future)
fe4335d
to
eea1ea0
Compare
@astrofrog I've rebased and moved the changelog entry to the 1.6.0 section. |
Could you check the codestyle failure with |
Hmm - it looks like the codestyle failure is actually coming from the main branch. Taking a quick look there, the codestyle check went from succeeding to failing after #2300 was merged - although codestyle passed in that PR and didn't change any of the offending files. I think the culprit is the E275 update described here. |
Thanks for identifying this @Carifio24 . The codestyle is fixed in #2308 now. |
There is currently a bug where any minor ticks displayed will not match the user's global settings. (Note that this isn't an issue with the default settings, since the labels are black either way.) One prominent example is the scientific notation tick marks that are sometimes used when displaying an axis in log mode. See below for an example:
This occurs because we only set major tick labels to match the given color in
set_foreground_color
(see the matplotlib documentation here; the default value forwhich
is"major"
). This PR fixes the issue by settingwhich="both"
).