Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on h5py causing incompatibility with Python 3.11 #2340

Closed
pllim opened this issue Oct 24, 2022 · 12 comments
Closed

Dependency on h5py causing incompatibility with Python 3.11 #2340

pllim opened this issue Oct 24, 2022 · 12 comments

Comments

@pllim
Copy link
Contributor

pllim commented Oct 24, 2022

glue/setup.cfg

Line 44 in b8f51d8

h5py>=2.10

will cause downstream packages to not able to install in Python 3.11 even though they do not use h5py until this issue is fixed:

Related problem:

@astrofrog
Copy link
Member

@dhomeier maybe we can just mark the dependency as being conditional on python<3.11?

@dhomeier
Copy link
Collaborator

Is this still not fixed? Installing h5py=3.7.0 worked just fine e.g. in https://github.com/glue-viz/glue/actions/runs/3267646674/jobs/5373107881 .

@pllim
Copy link
Contributor Author

pllim commented Oct 24, 2022

3.7 was released back in May. It didn't work when I tried a few weeks ago but I am trying again now with the released version.

@pllim
Copy link
Contributor Author

pllim commented Oct 24, 2022

Though the point is... why do I even have to bother? Jdaviz does not use HDF5.

@dhomeier
Copy link
Collaborator

OK I'll see if it's just to keep those tests from complaining (but it really should be in all and tests extras then), or if there are some deeper-lying problems as with the glue-astronomy translators. Most tests do check for install status of h5py, but I see some failures related to data_factories – no obvious connection to HDF5 files, though.

@astrofrog
Copy link
Member

Though the point is... why do I even have to bother? Jdaviz does not use HDF5.

But glue does - and jdaviz made the choice to depend on glue. We can't remove dependencies that give glue users a good user experience just because they aren't used by jdaviz. Maybe one day if pip supports the ability to do [minimal] (see astropy/astropy#12448 (comment)) then that will help?

@pllim
Copy link
Contributor Author

pllim commented Oct 24, 2022

"minimal" would be nice, but right now, it doesn't make sense for Jdaviz to build h5py from source in its CI and I am not sure when h5py would release wheel for Python 3.11. Is HDF5 a compulsory file format for Glue? That is unfortunate.

@astrofrog
Copy link
Member

astrofrog commented Oct 24, 2022

We do want to install h5py by default for glue users but of course since there are no wheels right now we should not require it on Python 3.11 yet if it doesn't install easily from source, which is what I mentioned in #2340 (comment) - I just meant that we can't remove h5py as a dependency altogether.

@pllim
Copy link
Contributor Author

pllim commented Oct 24, 2022

OK, see #2341

@dhomeier
Copy link
Collaborator

There are the [recommended] etc. install options, but not having everything with pip install glueviz obviously still has the potential for confusion, as in #2336.

@dhomeier
Copy link
Collaborator

h5py wheels are coming along in h5py/h5py#2165

@pllim
Copy link
Contributor Author

pllim commented Oct 28, 2022

Addressed by #2321

@pllim pllim closed this as completed Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants