Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Test against Python 3.11 #1654

Merged
merged 1 commit into from
Oct 28, 2022
Merged

TST: Test against Python 3.11 #1654

merged 1 commit into from
Oct 28, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 16, 2022

Description

This pull request is to see how badly things break in Python 3.11 (using RC2).

Blocked by

No longer an issue

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added this to the 2.11 milestone Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 87.82% // Head: 87.83% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (e646f84) compared to base (36d4c9f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1654   +/-   ##
=======================================
  Coverage   87.82%   87.83%           
=======================================
  Files          95       95           
  Lines       10178    10178           
=======================================
+ Hits         8939     8940    +1     
+ Misses       1239     1238    -1     
Impacted Files Coverage Δ
jdaviz/utils.py 90.26% <0.00%> (+0.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim
Copy link
Contributor Author

pllim commented Sep 16, 2022

Nope... regions and h5py need to catch up first. We can revisit this PR when they do. (So close!)

What is pulling in h5py? We do not use it.

@pllim

This comment was marked as outdated.

@dhomeier
Copy link
Collaborator

Installing (building yourself, probably) h5py for py311 at least at this time, for rc2, requires libhdf5-dev (possibly also libopenblas-dev, but that's probably for numpy/scipy) in the apt libs, and hdf5 from brew.

@pllim
Copy link
Contributor Author

pllim commented Oct 24, 2022

I didn't mean to build h5py from source. The released version wasn't working but since you said it is supposed to work now, let's see.

@dhomeier
Copy link
Collaborator

From what I can tell from the log, it has to build the wheel itself. See glue-viz/glue#2321 for reference.

@pllim
Copy link
Contributor Author

pllim commented Oct 24, 2022

That is kinda painful for something that we don't even use here.

@rosteen rosteen modified the milestones: 3.1, 3.2 Oct 26, 2022
TST: Allow build numpy/scipy from source when needed
from their nightlies

TST: Use dev regions for devdeps
@pllim pllim changed the title TST: Test against Python 3.11 RC2 TST: Test against Python 3.11 Oct 28, 2022
@pllim pllim added no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two labels Oct 28, 2022
@pllim pllim marked this pull request as ready for review October 28, 2022 19:26
@pllim
Copy link
Contributor Author

pllim commented Oct 28, 2022

We can now officially add Python 3.11 to our CI. 😸

@pllim pllim merged commit 0333346 into spacetelescope:main Oct 28, 2022
@pllim pllim deleted the tst-py311 branch October 28, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants