Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix typo in test case #2367

Merged
merged 1 commit into from
Mar 21, 2023
Merged

TST: Fix typo in test case #2367

merged 1 commit into from
Mar 21, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Feb 23, 2023

Just a small typo.

@pllim
Copy link
Contributor Author

pllim commented Feb 23, 2023

Surely one typo fix can't fail this horribly in the CI.

@Carifio24
Copy link
Member

The matplotlib 3.7 update broke a few of the CI tests. #2366 fixes one of them; the other four have a common issue (discrepancy in legend location) but I'm not sure yet what's actually causing the change in behavior.

@dhomeier dhomeier added the no-changelog-entry-needed Skipped in Changelog generation label Mar 21, 2023
Copy link
Collaborator

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, all failures are unrelated/fixed elsewhere. Should be merged as soon as #2370 is.

@dhomeier dhomeier merged commit e5229ad into glue-viz:main Mar 21, 2023
@dhomeier
Copy link
Collaborator

Thanks for the fix!

@pllim pllim deleted the patch-1 branch March 21, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed Skipped in Changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants