Make sure __getitem__ always returns a numpy array #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
requested changes
May 12, 2023
glue/core/component.py
Outdated
| @@ -536,7 +536,7 @@ def ndim(self): | |||
| return len(self._data.shape) | |||
|
|
|||
| def __getitem__(self, key): | |||
| return self._data[key].compute() | |||
| return np.array(self._data[key].compute()) | |||
There was a problem hiding this comment.
I think it would be better to use np.asarray in case the result of the computation is already a Numpy array, otherwise it will be unnecessarily copied in this case.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
In some circumstances, dask.compute() can still return a dask array (rather than the desired numpy array). I was able to trigger this with an external data loader library that presumably falls foul of this bug. Explicit to np.array fixes this for my use case and seems otherwise totally innocuous.
I am not providing a new unit test because I'm not sure how to reliably reproduce the extra-lazy dask array outside of the specific data loading library I was using.
Fixes #2397