Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure __getitem__ always returns a numpy array #2399

Merged
merged 2 commits into from
May 12, 2023
Merged

Make sure __getitem__ always returns a numpy array #2399

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ca2ed9
Make sure __getitem__ always returns a numpy array
jfoster17 May 8, 2023
9495a8b
Use np.asarray to prevent copy
jfoster17 May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion glue/core/component.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@ def ndim(self):
return len(self._data.shape)

def __getitem__(self, key):
return self._data[key].compute()
return np.array(self._data[key].compute())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to use np.asarray in case the result of the computation is already a Numpy array, otherwise it will be unnecessarily copied in this case.


@property
def numeric(self):
Expand Down