Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare testnet 3.39 #527

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Prepare testnet 3.39 #527

merged 1 commit into from
Nov 18, 2024

Conversation

beqaabu
Copy link
Contributor

@beqaabu beqaabu commented Nov 18, 2024

  • update tx payment pallet LengthToFee TransactionByteFee

  • fix clippy

  • cargo toml to v 39

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

* update tx payment pallet LengthToFee TransactionByteFee

* fix clippy

* cargo toml to v 39
@beqaabu beqaabu marked this pull request as ready for review November 18, 2024 16:49
@beqaabu beqaabu mentioned this pull request Nov 18, 2024
9 tasks
@atodorov
Copy link
Contributor

https://github.com/gluwa/creditcoin3/actions/runs/11897088100/job/33150510675?pr=527 is false positive, same explanation as in #525 (comment) b/c it is the same changes that are brought up in this PR.

Note: arguably the wording in the check script is chosen poorly. Should be something like " MILLISECS_PER_BLOCK detected in change request!"

Copy link

For full LLVM coverage report click here!

@DylanVerstraete DylanVerstraete merged commit 887c639 into testnet Nov 18, 2024
54 of 55 checks passed
@DylanVerstraete DylanVerstraete deleted the devnet-fix-fees branch November 18, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants