Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update tx payment pallet config #525

Merged
merged 3 commits into from
Nov 15, 2024
Merged

feat: update tx payment pallet config #525

merged 3 commits into from
Nov 15, 2024

Conversation

rustlang-dev
Copy link
Contributor

Description of proposed changes

update tx payment pallet config

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov
Copy link
Contributor

https://github.com/gluwa/creditcoin3/actions/runs/11859392335/job/33052219116?pr=525 - false positive - detecting MILLISECS_PER_BLOCK b/c it is in the git diff context. Can be ignored.

@atodorov
Copy link
Contributor

https://github.com/gluwa/creditcoin3/actions/runs/11859392339/job/33052220888?pr=525 - secretleaks issue intorduced in #483, can be ingored here.

@github-actions GitHub Actions
Copy link

For full LLVM coverage report click here!

BradleyOlson64
BradleyOlson64 previously approved these changes Nov 15, 2024
View reviewed changes
beqaabu
beqaabu previously approved these changes Nov 15, 2024
View reviewed changes
@beqaabu
Copy link
Contributor

beqaabu commented Nov 15, 2024

clippy unhappy https://github.com/gluwa/creditcoin3/actions/runs/11859392338/job/33052222887?pr=525

beqaabu
beqaabu previously approved these changes Nov 15, 2024
View reviewed changes
@dave1374 dave1374 merged commit 18154ec into dev Nov 15, 2024
49 of 53 checks passed
beqaabu pushed a commit that referenced this pull request Nov 18, 2024
@rustlang-dev @beqaabu
feat: update tx payment pallet config (#525)
c644116 
* update tx payment pallet LengthToFee TransactionByteFee

* fix clippy

* cargo toml to v 39
@atodorov atodorov mentioned this pull request Nov 18, 2024
Merged
9 tasks
DylanVerstraete pushed a commit that referenced this pull request Nov 18, 2024
@beqaabu @rustlang-dev
feat: update tx payment pallet config (#525) (#527)
887c639 
* update tx payment pallet LengthToFee TransactionByteFee

* fix clippy

* cargo toml to v 39

Co-authored-by: rust dev <rust.lang.developer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradleyOlson64 BradleyOlson64 BradleyOlson64 approved these changes

@DylanVerstraete DylanVerstraete DylanVerstraete approved these changes

@beqaabu beqaabu beqaabu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rustlang-dev @atodorov @beqaabu @DylanVerstraete @BradleyOlson64 @dave1374