Handle polkadot forks #483

rustlang-dev · 2024-09-17T14:16:30Z

Description of proposed changes

Handle polkadot forks
Clean up and refactoring in progress.

Practical tips for PR review & merge:

All GitHub Actions report PASS
Newly added code/functions have unit tests
- Coverage tools report all newly added lines as covered
- The positive scenario is exercised
- Negative scenarios are exercised, e.g. assert on all possible errors
- Assert on events triggered if applicable
- Assert on changes made to storage if applicable
Modified behavior/functions - try to make sure above test items are covered
Integration tests are added if applicable/needed

for more information, see https://pre-commit.ci

use latest polkadot sdk and frontier versions: stable2407

for more information, see https://pre-commit.ci

…ade-finished feat: creditcoin3 runtime polkadot/frontier dependency finished.

for more information, see https://pre-commit.ci

feat: update frontier rpc trace to the latest version of polkadot.

fix FrontierBackend

feat: upgrade cc3 node to latest frontier, polkadot sdk + todo

for more information, see https://pre-commit.ci

fix: run of Subcommand::FrontierDb inside node

beqaabu

looking good so far but needs cleanup

feat: metrics for full node, refactoring

github-actions · 2024-09-23T13:44:06Z

For full LLVM coverage report click here!

fix: cc3 forks fix ci after updating fork of frontier and polkadot sdk

atodorov · 2024-09-24T08:35:17Z

From integration-tests-cli:

Error: src/lib/staking/bond.ts(69,37): error TS2554: Expected 7 arguments, but got 6.
error Command failed with exit code 2.

This will have an impact on 2 fronts:

Most likely Creditcoin 3 Staking Dashboard will be affected and will need to be updated as well
Older creditcoin-cli clients (e.g. ones which don't upgrade their docker images) won't be able to bond (probably other operations too) after the runtime upgrade occurs. That would generate lots of support calls from the community and some degree of bad publicity so it needs to be communicated well in advance.

atodorov · 2024-09-24T08:38:20Z

precompiles/substrate-transfer/src/mock.rs

+
+    type RuntimeFreezeReason = RuntimeFreezeReason;
+    // type FreezeIdentifier = RuntimeFreezeReason;
+    // type MaxFreezes = frame_support::traits::VariantCountOf<RuntimeFreezeReason>;


IMO remove comments if not in use. Better keep the code base cleaner.

feat: chopsticks

feat: check migration locally. new runtime on top of old node + runtime

atodorov

Minor issues noted.

However while at it it would be great to rebase this PR in order to solve a conflict in Cargo.toml as well as get rid of all the "Merge " commits currently present.

atodorov · 2024-10-11T09:36:37Z

cc3.yml

+
+import-storage:
+  Sudo:
+    Key: 5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY # Alice


Triggers gitleaks -> https://github.com/gluwa/creditcoin3/actions/runs/11077595872/job/31400820960?pr=483

which seems like a false positive. You can disable it in .gitleaksignore, see the logs for more details.

Note: I think when the commit hash changes .gitleaksignore needs to be updated!

atodorov · 2024-10-11T09:37:19Z

cc3.yml

@@ -0,0 +1,17 @@
+endpoint: wss://mainnet3.creditcoin.network


Suggestion: why not name this file chopsticks.yml or chopsticks-config.yml or something similar that would make it obvious what it is for ?

atodorov · 2024-10-11T09:38:08Z

cc3.yml

+allow-unresolved-imports: true
+mock-signature-host: true
+# wasm-override: /Users/mykyta/dev/gluwa/creditcoin3-before-forks-update/target/release/wbuild/creditcoin3-runtime/creditcoin3_runtime.compact.compressed.wasm
+


Nitpick: file can be reformatted with prettier ->
https://github.com/gluwa/creditcoin3/actions/runs/11077595872/job/31400820960?pr=483

rustlang-dev and others added 30 commits September 6, 2024 22:18

update dependency of polkadot and frontier

cb34f83

cargo lock

8fb4c7a

latest polkadot and frontier.

fbeaf6e

[pre-commit.ci] auto fixes from pre-commit.com hooks

392e5a5

for more information, see https://pre-commit.ci

Merge pull request #459 from gluwa/fix-issue-with-dependency

2a4782e

use latest polkadot sdk and frontier versions: stable2407

creditcoin runtime polkadot/frontier dependency finished.

beef936

[pre-commit.ci] auto fixes from pre-commit.com hooks

f1720aa

for more information, see https://pre-commit.ci

Merge pull request #460 from gluwa/creditcoin-runtime-dependency-upgr…

5cdcb6b

…ade-finished feat: creditcoin3 runtime polkadot/frontier dependency finished.

update frontier rpc trace to the latest version of polkadot.

8adca47

[pre-commit.ci] auto fixes from pre-commit.com hooks

d6e28b4

for more information, see https://pre-commit.ci

Merge pull request #461 from gluwa/frontier-trace-fix

f97f2b9

feat: update frontier rpc trace to the latest version of polkadot.

fix overrides evm cache task.

7c2eb1a

fix spawn_frontier_tasks compilation.

57ab220

fix overrides, metrics.

ea31870

fix frontier_backend

e8a83c9

FrontierBackend

80db869

fix FrontierBackend

738a11b

Merge pull request #463 from gluwa/fix-frontier-backend

2b2ed4a

fix FrontierBackend

fix genesis.

9d026cd

fix ChainSpec

aae4b87

upgrade cc3 node to latest frontier, polkadot sdk but still some todo

b69d1d2

add todo!

4e66ed7

Merge pull request #470 from gluwa/cc3-node-upgrade-with-todo

9703f74

feat: upgrade cc3 node to latest frontier, polkadot sdk + todo

fix and enable offchain-workers-runner spawn.

24d93e6

remove 2 todos

0ac21d1

fix 2 todos about grandpa notification inside new_full node fn.

d2bcdd7

fix run of Subcommand::FrontierDb

63d9c7f

[pre-commit.ci] auto fixes from pre-commit.com hooks

a0835ea

for more information, see https://pre-commit.ci

Merge pull request #479 from gluwa/fix-run-subcommand-frontierdb

b235b8f

fix: run of Subcommand::FrontierDb inside node

fix new_full fn that now match &frontier_backend into EthDeps struct

90936ea

rustlang-dev marked this pull request as draft September 17, 2024 14:17

rustlang-dev requested a review from DylanVerstraete September 17, 2024 14:17

rustlang-dev added 3 commits September 19, 2024 15:23

refactoring after migration to latest polkadot-sdk/frontier.

42afc52

register metrics with prometheus for node service new_full fn

1d6ef0f

cargo fmt --

261e314

beqaabu reviewed Sep 19, 2024

View reviewed changes

rustlang-dev added 3 commits September 23, 2024 12:20

fix some clippy.

cad984a

fix unit tests build. tests passed.

c83dc66

Merge pull request #496 from gluwa/forks-refactoring

57910a0

feat: metrics for full node, refactoring

rustlang-dev marked this pull request as ready for review September 23, 2024 13:14

rustlang-dev added 2 commits September 23, 2024 14:21

Merge branch 'dev' into handle-polkadot-forks

2262ad6

remove frontier and polkadot-sdk from check for used forks .sh

5eaa4c8

rustlang-dev added 5 commits September 23, 2024 14:47

whitelist github.com/paritytech frontier and polkadot-sdk

a5be334

fix clippy

4271f99

fix all lints to allow deprecated fn

a8b5918

cargo fmt

8c70c7e

Merge pull request #497 from gluwa/cc3-forks-fix-ci

281bb2d

fix: cc3 forks fix ci after updating fork of frontier and polkadot sdk

atodorov requested changes Sep 24, 2024

View reviewed changes

rustlang-dev added 5 commits September 25, 2024 20:27

check migration locally. new runtime on top of old node + runtime

2ec4660

add file to run chopstics

a685ce5

update readme about chopsticks

75173a5

Merge pull request #502 from gluwa/chopstics-yml

bb1b984

feat: chopsticks

Merge pull request #500 from gluwa/migration-local-test

3fdc7ae

feat: check migration locally. new runtime on top of old node + runtime

atodorov requested changes Oct 11, 2024

View reviewed changes

atodorov mentioned this pull request Oct 11, 2024

CSUB-1322: Include repository name as part of self-hosted runner hostname #508

Merged

9 tasks

atodorov mentioned this pull request Oct 22, 2024

build(deps): bump secp256k1 from 4.0.3 to 4.0.4 in /testing #510

Merged

This was referenced Nov 15, 2024

feat: update tx payment pallet config #525

Merged

CSUB-1374: Tell gitleaks to scan only commits in the current PR #529

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle polkadot forks #483

Handle polkadot forks #483

rustlang-dev commented Sep 17, 2024 •

edited

Loading

beqaabu left a comment

github-actions bot commented Sep 23, 2024

atodorov commented Sep 24, 2024

atodorov Sep 24, 2024

atodorov left a comment

atodorov Oct 11, 2024

atodorov Oct 11, 2024

atodorov Oct 11, 2024

Handle polkadot forks #483

Are you sure you want to change the base?

Handle polkadot forks #483

Conversation

rustlang-dev commented Sep 17, 2024 • edited Loading

Description of proposed changes

beqaabu left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 23, 2024

atodorov commented Sep 24, 2024

atodorov Sep 24, 2024

Choose a reason for hiding this comment

atodorov left a comment

Choose a reason for hiding this comment

atodorov Oct 11, 2024

Choose a reason for hiding this comment

atodorov Oct 11, 2024

Choose a reason for hiding this comment

atodorov Oct 11, 2024

Choose a reason for hiding this comment

rustlang-dev commented Sep 17, 2024 •

edited

Loading