Disregard internal href #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhelding
approved these changes
Oct 21, 2019
| if self._href is not None: | ||
| return self._href | ||
| # if self._href is not None: | ||
| # return self._href |
There was a problem hiding this comment.
Is there a reason to keep this code here commented out? Otherwise, good to merge.
|
@khalidharun: one small comment / suggestion, but have marked as approved so can be merged at your discretion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The API client errors when trying to access nested resources. This happens because each resource has an HREF resource url attached to it but this resource url is based on an internal hostname which isn't accessible in Azure.
This PR makes the host url based on parent's hostname.