Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disregard internal href #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disregard internal href #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ambariclient/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,9 +590,11 @@ def url(self):
Otherwise, it will generated it based on the collection's url and the
model's identifier.
"""
if self._href is not None:
return self._href
# if self._href is not None:
# return self._href
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to keep this code here commented out? Otherwise, good to merge.

if self.identifier:
if self.identifier == 'Unknown':
return self.parent.url
return '/'.join([self.parent.url, self.identifier])
raise exceptions.ClientError("Not able to determine object URL")

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

setuptools.setup(
name="python-ambariclient",
version="0.6.0",
version="0.6.1",
author="Rackspace",
author_email="greg.hill@rackspace.com",
description="Client library for Apache Ambari.",
Expand Down