Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock all languages #34

Closed
wants to merge 1 commit into from
Closed

Unlock all languages #34

wants to merge 1 commit into from

Conversation

hyww
Copy link

@hyww hyww commented Dec 9, 2022

resolves #29

I found this showAllSubDubTracks option in manifest requests and it works like a charm.

This might bring a new issue, too many languages! Maybe we need a way to let users filter the languages and display only those they are interested in.

Copy link
Owner

@gmertes gmertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was very excited about this, but I can't get it to reproduce on my end on either Chrome or Firefox 😭😭😭

There's no object with url field manifest on my end, I only see a licensedManifest, and this doesn't have showAllSubDubTracks. I also logged all stringify calls for a while and couldn't find any that contains showAllSubDubTracks :(

So not sure what to do about this. I am noticing differences between players, though. For example, on my laptop I don't see the extra languages at all, while I do on my desktop (same show, same account, same browser). Not sure what's causing this, maybe related..

@hyww
Copy link
Author

hyww commented Dec 10, 2022

Sorry, my fault. I didn't noticed that I also installed this extension, which uses a modified version of older cadmium player. P.S. that version still uses the old subtitle downloadUrls 😂

I will close this PR and leave some comments at #29 for further discussion.

@hyww hyww closed this Dec 10, 2022
@gmertes
Copy link
Owner

gmertes commented Dec 10, 2022

Oh interesting, I also have a fork of netflix-1080p on my laptop so that explains the different player versions! 😅 But that one interestingly still doesn't work with showAllSubDubTracks

We may consider adding this as an optional feature and then instruct the user to install netflix-1080p ? But the original version is no longer maintained, and I don't know the impact of sticking with the older player version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for extra out-of-region languages
2 participants