Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock all languages #35

Closed
wants to merge 1 commit into from
Closed

Unlock all languages #35

wants to merge 1 commit into from

Conversation

hyww
Copy link

@hyww hyww commented Dec 10, 2022

resolves #29

Let me try again. This time I've tested with different versions of cadium-playercore 6.0033.414.911, 6.0034.588.911, 6.0038.181.911 (latest?)

resolves gmertes#29
tested with cadium-playercore 6.0033.414.911, 6.0034.588.911, 6.0038.181.911
Copy link
Owner

@gmertes gmertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still unable to reproduce :( I tried all versions of the player (original on Chrome and FF, truedread/netflix-1080p on Chrome and TheGoddessInari/netflix-1080p-firefox on FF). Setting supportsPartialHydration to false even disables all the extra languages for me (and I only see the 'original' languages in the primary subtitle list).

Are you sure you can get it to reproduce even with the original player and no other extensions installed? Maybe it's a regional difference? Does it reproduce for you on all shows?

@hyww
Copy link
Author

hyww commented Dec 11, 2022

After some experiments watching Wednesday Ep.1 with VPN to different countries, I believe it is a regional difference.

With VPN to UK, I got only these 'original' languages. (I prefer call them 'recommended' languages.) I guess this is similar with what you've seen (except zh-Hant, which is my Netflix profile preference).

> __NflxMultiSubs.manifestManager.manifests[81257204].timedtexttracks.filter(a=>a.rank!=-1).map(a=>a.language)
['zh-Hant', 'en', 'ar', 'fr', 'pl', 'uk', 'fr', 'fr']

From Taiwan or with VPN to US, Japan, I got these

['en', 'zh-Hant', 'ar', 'ca', 'cs', 'da', 'de', 'el', 'es-ES', 'es', 'eu', 'fil', 'fi', 'fr', 'gl', 'he', 'hr', 'hu', 'id', 'it', 'ja', 'ko', 'ms', 'nb', 'nl', 'pl', 'pt-BR', 'pt', 'ro', 'ru', 'sv', 'th', 'tr', 'uk', 'vi', 'zh-Hans', 'cs', 'es', 'fr', 'hu', 'pt-BR', 'hu', 'fr', 'cs']

My hypothesis is that Netflix is deprecating showAllSubDubTracks, but this server-side change takes time to apply to all regions. Thus this PR is a work-around for some regions for now, not a long-term solution 😥

@gmertes
Copy link
Owner

gmertes commented Dec 11, 2022

I'm reluctant to merge even if it does work now for some regions, because it makes things worse for other regions by hiding the 'extra' languages from the primary subs list. Does it work for you without supportsPartialHydration = false ?

Many thanks for your work in investigating this! Would be great if we can get this to work for everyone.

@hyww
Copy link
Author

hyww commented Dec 12, 2022

Without supportsPartialHydration = false, showAllSubDubTracks has no effects. (like #34 (comment) )

@hyww hyww closed this Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for extra out-of-region languages
2 participants