Detect bad gno.mod configuration from CI #927
Labels
🐞 bug
Something isn't working
🗺️good first issue🗺️
Ideal for newcomer contributors
help wanted
Want to contribute? We recommend these issues.
Milestone
Comments
moul
added
🗺️good first issue🗺️
|
cc @harry-hov, @thehowl |
moul
added a commit
that referenced
this issue
Jul 31, 2023
This PR introduces a new `gno lint` subcommand, currently focused on checking for the presence of a `gno.mod` file in a package, and it's linked with the CI. In the future, we plan to expand `gno lint` to support additional checks, enhancing its utility for developers and CI integration. Addresses #850 Addresses #927 Related with #965 (comment) Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com> Co-authored-by: Miloš Živković <milos@zmilos.com>
Doozers
pushed a commit
to Doozers/gno
that referenced
this issue
Aug 31, 2023
This PR introduces a new `gno lint` subcommand, currently focused on checking for the presence of a `gno.mod` file in a package, and it's linked with the CI. In the future, we plan to expand `gno lint` to support additional checks, enhancing its utility for developers and CI integration. Addresses gnolang#850 Addresses gnolang#927 Related with gnolang#965 (comment) Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com> Co-authored-by: Miloš Živković <milos@zmilos.com>
Kouteki
added
help wanted
|
Cycles are now detected, because we test gno.land also for simple changes to examples/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR #882 introduced a bug (#882) that went unnoticed until after it was merged. It was fixed with PR #921.
The issue arises from the current cycle detection tool, which is only tested with
./gno.land, when relevant go files are updated, not when the./examplesfolder is modified in a pull request.To address this, we should update the
examples.ymlworkflow to include cycle checks. In the long term, it would be ideal to develop agno linttool (#850) to thoroughly check for cycles in the entire example folder.The text was updated successfully, but these errors were encountered: