Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial 'gno lint' #981

Merged
merged 10 commits into from
Jul 31, 2023
Merged

feat: initial 'gno lint' #981

merged 10 commits into from
Jul 31, 2023

Conversation

moul
Copy link
Member

@moul moul commented Jul 20, 2023 •
edited
Loading

This PR introduces a new gno lint subcommand, currently focused on checking for the presence of a gno.mod file in a package, and it's linked with the CI. In the future, we plan to expand gno lint to support additional checks, enhancing its utility for developers and CI integration.

  • new gno lint command
  • check for missing/invalid gno.mod
  • add comments for upcoming needed linters
  • setup CI checking the examples/ folder
  • update docs/ folder

Addresses #850
Addresses #927
Related with #965 (comment)

Checklists...

Contributors Checklist

  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Maintainers Checklist

  • Checked that the author followed the guidelines in CONTRIBUTING.md
  • Checked the conventional-commit (especially PR title and verb, presence of BREAKING CHANGE: in the body)
  • Ensured that this PR is not a significant change or confirmed that the review/consideration process was appropriate for the change

@moul
feat: initial 'gno lint'
8bbacce 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul self-assigned this Jul 20, 2023
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jul 20, 2023
@moul moul mentioned this pull request Jul 20, 2023
Merged
10 tasks
@moul
chore: fixup
7fc64b5 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@harry-hov
Copy link
Contributor

harry-hov wrote:
I miss gno.mod files :)

moul wrote:
@harry-hov, we need an explicit CI check for this.

I had the same thought. Although I wanted to do this with gno mod tidy.

@moul moul mentioned this pull request Jul 20, 2023
Open
moul added 4 commits July 20, 2023 15:30
@moul
chore: fixup
e890d6e 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
chore: fixup
710a339 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
chore: lint on ci
fd013ff 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
chore: fix current examples folder for lint
ed38d4c 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jul 20, 2023
moul added 2 commits July 22, 2023 10:21
@moul
chore: fixup
b17f5d2 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
chore: update docs
c1e25db 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul marked this pull request as ready for review July 27, 2023 17:13
@moul moul requested a review from a team as a code owner July 27, 2023 17:13
@moul moul mentioned this pull request Jul 27, 2023
Open
3 tasks
zivkovicmilos
zivkovicmilos approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

gnovm/cmd/gno/lint.go Outdated Show resolved Hide resolved
moul and others added 2 commits July 31, 2023 17:13
@moul @zivkovicmilos
Update gnovm/cmd/gno/lint.go
58a6bcd 
Co-authored-by: Miloš Živković <milos@zmilos.com>
@moul
chore: fix docker-integration test
b2bd5c8 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul merged commit 3ade982 into gnolang:master Jul 31, 2023
@moul moul deleted the dev/moul/gno-lint branch July 31, 2023 16:24
Doozers pushed a commit to Doozers/gno that referenced this pull request Aug 31, 2023
@moul @zivkovicmilos @Doozers
feat: initial 'gno lint' (gnolang#981)
ed80916 
This PR introduces a new `gno lint` subcommand, currently focused on
checking for the presence of a `gno.mod` file in a package, and it's
linked with the CI. In the future, we plan to expand `gno lint` to
support additional checks, enhancing its utility for developers and CI
integration.

Addresses gnolang#850
Addresses gnolang#927
Related with
gnolang#965 (comment)

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Miloš Živković <milos@zmilos.com>
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@ajnavarro ajnavarro Awaiting requested review from ajnavarro

Assignees

@moul moul

Labels
📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
😎 Manfred's Board
Status: ✅ Done
🚀 The Launch [DEPRECATED]
Archived in project
🧐 Review Meeting
Archived in project
Milestone
DEPRECATED:🌟 main.gno.land (wanted)
Development

Successfully merging this pull request may close these issues.
3 participants
@moul @harry-hov @zivkovicmilos