-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amino): Add TypeDesc Amino implementation and TypedValue
marshaler
#2113
Draft
gfanton
wants to merge
11
commits into
gnolang:master
Choose a base branch
from
gfanton:feat/typed-values-marshal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
github-actions
bot
added
📦 🤖 gnovm
Issues or PRs gnovm related
📦 🌐 tendermint v2
Issues or PRs tm2 related
labels
May 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2113 +/- ##
==========================================
+ Coverage 49.04% 49.07% +0.03%
==========================================
Files 576 578 +2
Lines 77556 77937 +381
==========================================
+ Hits 38035 38250 +215
- Misses 36439 36581 +142
- Partials 3082 3106 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
gfanton
force-pushed
the
feat/typed-values-marshal
branch
from
May 15, 2024 15:37
e0997a5
to
9dd01a1
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS: This PR is still in draft, but I would welcome any feedback on it
This PR has two main objectives. The first is to add a
TypeDesc
method implementation to Amino, allowing a type to self-describe. The second is to introduce a new package,gnoamino
, dedicated to (un)marshaling Gno types, starting withgnolang.TypedValue
and itsTypedValueWrapper
, which implements theTypeDesc
Amino method.Most of the methods in
TypedValueWrapper
are inspired by or copied fromgnonative.go
. They are exported here for several reasons:gnonative
are intended for general use and may be removed later, while the ones here are focused solely on marshaling and unmarshaling.TypedValue
, simplifying its management.Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description