Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: issue #1067 #3188

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

test: issue #1067 #3188

wants to merge 1 commit into from

Conversation

r3v4s
Copy link
Contributor

@r3v4s r3v4s commented Nov 25, 2024

txtar test to re-produce #1067, which is not re-producable.
// resolves #1067 (not sure if its okay to resolve it or not)

Main issue in #1067 was fee was being added on top of tx fee, which makes deduce twice from users's balance.

However it's not re-producable with current master branch.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@r3v4s r3v4s self-assigned this Nov 25, 2024
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

Bug: contract execution fee is added on top of the transaction fee.
1 participant