-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase max block gas limit #3384
base: master
Are you sure you want to change the base?
Conversation
Increase the block gas limit accordingly as we update the gas configuration.
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
TimeIotaMS: 100, // 100ms | ||
MaxTxBytes: 1_000_000, // 1MB, | ||
MaxDataBytes: 2_000_000, // 2MB, | ||
MaxGas: 3_000_000_000, // 3B gas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MaxGas: 3_000_000_000, // 3B gas | |
MaxGas: 10_000_000_000, // 10B gas |
I prefer round numbers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moul @thehowl, In the new gas configuration, one unit of gas is approximately equal to 1 nanosecond of execution time. Allowing 10 billion gas per block, which translates to 10 seconds of execution time per block, may be too large. For example, if the commit time is configured as 5 seconds, a duration of 3 seconds per block would be safer for a validator to join the network and catch up with the latest block playback. Even though these numbers are rough estimates, they provide a model and reference for modification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree to make it 10b
Increase the block gas limit accordingly as we update the gas configuration.