Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase max block gas limit #3384

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: increase max block gas limit #3384

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a9e279
Fix: increase max block gas limit
piux2 Dec 19, 2024
0bb1d21
fmt&lint
piux2 Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions gno.land/cmd/gnoland/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,10 +372,10 @@ func generateGenesisFile(genesisFile string, pk crypto.PubKey, c *startCfg) erro
gen.ConsensusParams = abci.ConsensusParams{
Block: &abci.BlockParams{
// TODO: update limits.
MaxTxBytes: 1_000_000, // 1MB,
MaxDataBytes: 2_000_000, // 2MB,
MaxGas: 100_000_000, // 100M gas
TimeIotaMS: 100, // 100ms
MaxTxBytes: 1_000_000, // 1MB,
MaxDataBytes: 2_000_000, // 2MB,
MaxGas: 3_000_000_000, // 3B gas
Copy link
Member

@moul moul Dec 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MaxGas: 3_000_000_000, // 3B gas
MaxGas: 10_000_000_000, // 10B gas

I prefer round numbers.

Copy link
Contributor Author

@piux2 piux2 Dec 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moul @thehowl, In the new gas configuration, one unit of gas is approximately equal to 1 nanosecond of execution time. Allowing 10 billion gas per block, which translates to 10 seconds of execution time per block, may be too large. For example, if the commit time is configured as 5 seconds, a duration of 3 seconds per block would be safer for a validator to join the network and catch up with the latest block playback. Even though these numbers are rough estimates, they provide a model and reference for modification.

TimeIotaMS: 100, // 100ms
},
}

Expand Down
Loading