Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solidity linter #104

Merged
merged 2 commits into from
May 11, 2018
Merged

Add solidity linter #104

merged 2 commits into from
May 11, 2018

Conversation

fvictorio
Copy link
Contributor

This adds Solhint to improve code quality and security on solidity contracts.

No modifications were made to the contracts, but the emitted warnings should help make the code comply with the style guide.

@codecov-io
Copy link

Codecov Report

Merging #104 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          27       27           
  Lines         758      758           
  Branches      111      111           
=======================================
  Hits          695      695           
  Misses         63       63

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd9079a...a9cc3f3. Read the comment docs.

@cag
Copy link
Contributor

cag commented May 11, 2018

Thank you!

BTW for reference, addresses this: #69

@cag cag merged commit ab22bf9 into gnosis:master May 11, 2018
@collinc97 collinc97 mentioned this pull request Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants