Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase linter #129

Merged
merged 3 commits into from
Aug 14, 2018
Merged

Rebase linter #129

merged 3 commits into from
Aug 14, 2018

Conversation

collinc97
Copy link
Contributor

Rebased commits onto development branch from master #104.
Solves #69.

@collinc97 collinc97 requested a review from cag August 14, 2018 02:05
Copy link
Contributor

@cag cag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add solhint to the project and also the associated script which was lost in the rebase please?

Copy link
Contributor Author

@collinc97 collinc97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented fixes

Copy link
Contributor Author

@collinc97 collinc97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script and version added

@@ -9,6 +9,7 @@
"migrate": "truffle migrate",
"networks": "truffle networks",
"test": "truffle test",
"lint-contracts": "solhint contracts/**/*.sol",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script added

@@ -38,6 +39,7 @@
"lodash": "^4.17.4",
"npm-prepublish": "^1.2.3",
"truffle": "^4.0.4",
"solhint": "^1.1.10",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version added

Copy link
Contributor

@cag cag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solhint is not quite ready to run on this repo, but this is solid prep work 👍

@cag cag merged commit 6f57880 into development Aug 14, 2018
@cag cag deleted the rebase-linter branch August 14, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants