-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase linter #129
Rebase linter #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add solhint
to the project and also the associated script which was lost in the rebase please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
script and version added
@@ -9,6 +9,7 @@ | |||
"migrate": "truffle migrate", | |||
"networks": "truffle networks", | |||
"test": "truffle test", | |||
"lint-contracts": "solhint contracts/**/*.sol", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
script added
@@ -38,6 +39,7 @@ | |||
"lodash": "^4.17.4", | |||
"npm-prepublish": "^1.2.3", | |||
"truffle": "^4.0.4", | |||
"solhint": "^1.1.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solhint
is not quite ready to run on this repo, but this is solid prep work 👍
Rebased commits onto development branch from master #104.
Solves #69.