Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize Routes #26

Closed
cristovaoth opened this issue Jan 8, 2025 · 0 comments · Fixed by #27 or #29
Closed

Normalize Routes #26

cristovaoth opened this issue Jan 8, 2025 · 0 comments · Fixed by #27 or #29
Assignees
@cristovaoth

Comments

@cristovaoth
Copy link
Contributor

Perform the following normalization tasks:

  • Verify that address fields are present, and convert them to lowercase to maintain the standard internal address format.
  • Check for missing fields, such as the threshold, and ensure they are queried and filled appropriately.
@cristovaoth cristovaoth self-assigned this Jan 8, 2025
@cristovaoth cristovaoth mentioned this issue Jan 8, 2025
Merged
jfschwarz pushed a commit that referenced this issue Jan 8, 2025
@cristovaoth
feat: normalize routes (#27)
173c892 
This PR normalizes routes before planning, in a way that will fill in
threshold if that number is missing.

(Addresses the always propose bug)

closes #26
@github-actions github-actions bot mentioned this issue Jan 8, 2025
Merged
jfschwarz pushed a commit that referenced this issue Jan 9, 2025
@github-actions
chore(main): release 1.1.0 (#29)
b48ccbe 
🤖 I have created a release *beep* *boop*
---


##
[1.1.0](v1.0.7...v1.1.0)
(2025-01-09)


### Features

* new options for Safe transaction `nonce`: override and enqueue
([#28](#28))
([2ed336c](2ed336c)),
closes [#24](#24)
* normalize routes
([#27](#27))
([173c892](173c892)),
closes [#26](#26)
* replace assert with invariant in code to not require node environment
([#30](#30))
([de85648](de85648)),
closes [#20](#20)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cristovaoth cristovaoth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: normalize routes gnosisguild/ser-kit
chore(main): release 1.1.0 gnosisguild/ser-kit
1 participant
@cristovaoth