feat: replace assert with invariant in code to not require node environment #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
jfschwarz
reviewed
Jan 9, 2025
| assert(right != null) | ||
| invariant( | ||
| waypoint.account.type == AccountType.EOA, | ||
| `Expected account type to be "${AccountType.EOA}" but got "${waypoint.account.type}"` |
cristovaoth
approved these changes
Jan 9, 2025
jfschwarz
pushed a commit
that referenced
this pull request
Jan 9, 2025
🤖 I have created a release *beep* *boop* --- ## [1.1.0](v1.0.7...v1.1.0) (2025-01-09) ### Features * new options for Safe transaction `nonce`: override and enqueue ([#28](#28)) ([2ed336c](2ed336c)), closes [#24](#24) * normalize routes ([#27](#27)) ([173c892](173c892)), closes [#26](#26) * replace assert with invariant in code to not require node environment ([#30](#30)) ([de85648](de85648)), closes [#20](#20) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on gnosisguild/zodiac-pilot#469 I noticed that
ser-kitrelies on some node-specific modules. In this case,assert. While I know that there are ways of getting node modules into a browser bundle, I think for this specific case, using@epic-web/invariantinstead ofassertis also a good way forward. It eliminates the node dependency and makesser-kitwork more easily across environments.closes #20