Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1226 feat create nft images for positions #283

Merged
merged 11 commits into from
Jul 19, 2024
Merged

GSW-1226 feat create nft images for positions #283

merged 11 commits into from
Jul 19, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Jul 16, 2024

feat

  1. every nft position(when user provides liquidity), create random images based on gnoswap logo

@r3v4s r3v4s self-assigned this Jul 16, 2024
notJoon
notJoon previously approved these changes Jul 16, 2024
View reviewed changes
@r3v4s r3v4s force-pushed the GSW-1226-feat-create-nft-images-for-positions branch from 8a8f40e to 7fa0bf9 Compare July 16, 2024 05:15
@r3v4s r3v4s requested a review from notJoon July 16, 2024 05:15
jungju
jungju previously approved these changes Jul 16, 2024
View reviewed changes
AkydA
AkydA previously approved these changes Jul 16, 2024
View reviewed changes
@r3v4s r3v4s marked this pull request as draft July 16, 2024 14:39
@r3v4s
Copy link
Member Author

r3v4s commented Jul 16, 2024

will add std.Emit event for this

@adr-sk adr-sk mentioned this pull request Jul 17, 2024
Open
@r3v4s r3v4s dismissed stale reviews from AkydA, jungju, and notJoon via 54af970 July 18, 2024 09:40
@r3v4s r3v4s marked this pull request as ready for review July 18, 2024 09:40
jungju
jungju previously approved these changes Jul 18, 2024
View reviewed changes
@r3v4s
Copy link
Member Author

r3v4s commented Jul 19, 2024

closing, this change is included in #284

@r3v4s r3v4s closed this Jul 19, 2024
@dongwon8247 dongwon8247 reopened this Jul 19, 2024
@dongwon8247
Copy link
Member

@r3v4s Do not include irrelevant work in to a PR. Have them separately.

notJoon
notJoon previously approved these changes Jul 19, 2024
View reviewed changes
_deploy/r/gnoswap/gnft/svg_generator.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/gnft/svg_generator.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/gnft/svg_generator.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/gnft/svg_generator.gno Outdated Show resolved Hide resolved
@r3v4s r3v4s dismissed stale reviews from notJoon and jungju via e7161bf July 19, 2024 01:53
r3v4s and others added 5 commits July 19, 2024 10:53
@r3v4s @notJoon
Update _deploy/r/gnoswap/gnft/svg_generator.gno
e7161bf 
Co-authored-by: Lee ByeongJun <lbj199874@gmail.com>
@r3v4s @notJoon
Update _deploy/r/gnoswap/gnft/svg_generator.gno
55aa37b 
Co-authored-by: Lee ByeongJun <lbj199874@gmail.com>
@r3v4s @notJoon
Update _deploy/r/gnoswap/gnft/svg_generator.gno
c98f5ba 
Co-authored-by: Lee ByeongJun <lbj199874@gmail.com>
@r3v4s
fix: type issue
5f5434f
@r3v4s
test
f6d390a
@r3v4s r3v4s requested review from AkydA, notJoon and jungju July 19, 2024 02:57
@r3v4s r3v4s requested a review from jinoosss July 19, 2024 02:58
@r3v4s r3v4s merged commit 465c557 into main Jul 19, 2024
@r3v4s r3v4s deleted the GSW-1226-feat-create-nft-images-for-positions branch July 19, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongwon8247 dongwon8247 dongwon8247 approved these changes

@notJoon notJoon notJoon approved these changes

@mconcat mconcat Awaiting requested review from mconcat

@AkydA AkydA Awaiting requested review from AkydA

@jungju jungju Awaiting requested review from jungju

@jinoosss jinoosss Awaiting requested review from jinoosss

Assignees

@r3v4s r3v4s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@r3v4s @dongwon8247 @jungju @notJoon @AkydA