Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1308 fix: bug incentive data gets reset when a new pool is added into the emission list #284

Merged
merged 31 commits into from
Jul 29, 2024
Merged

GSW-1308 fix: bug incentive data gets reset when a new pool is added into the emission list #284

merged 31 commits into from
Jul 29, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Jul 18, 2024

fix

  1. incentive data gets reset when a new pool is added into the emission list

@r3v4s r3v4s self-assigned this Jul 18, 2024
jungju
jungju previously approved these changes Jul 18, 2024
View reviewed changes
notJoon
notJoon previously approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some minor suggestion and memo. Please check it out 👍

_deploy/r/gnoswap/gnft/svg_generator.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/gnft/svg_generator.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/gnft/svg_generator.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/gns/gns.gno Show resolved Hide resolved
staker/reward_math.gno Outdated Show resolved Hide resolved
@r3v4s r3v4s mentioned this pull request Jul 19, 2024
Merged
@r3v4s r3v4s marked this pull request as draft July 19, 2024 02:59
@r3v4s
Copy link
Member Author

r3v4s commented Jul 19, 2024

WIP

  • code of this branch will be deployed to dev env without merging it to master
  • when qa is done, most of debug code will be erased.

@r3v4s r3v4s dismissed stale reviews from notJoon and jungju via d7b1b16 July 19, 2024 03:01
@r3v4s r3v4s force-pushed the GSW-1308-bug-incentive-data-gets-reset-when-a-new-pool-is-added-into-the-emission-list branch from d7b1b16 to d08f01b Compare July 19, 2024 03:15
@r3v4s r3v4s requested a review from notJoon July 26, 2024 05:35
notJoon
notJoon previously approved these changes Jul 26, 2024
View reviewed changes
@r3v4s r3v4s force-pushed the GSW-1308-bug-incentive-data-gets-reset-when-a-new-pool-is-added-into-the-emission-list branch from f1994e3 to 1a02afb Compare July 29, 2024 01:05
@r3v4s r3v4s marked this pull request as ready for review July 29, 2024 02:44
@r3v4s r3v4s requested a review from notJoon July 29, 2024 02:44
@r3v4s r3v4s merged commit 6f2b4ca into main Jul 29, 2024
@r3v4s r3v4s deleted the GSW-1308-bug-incentive-data-gets-reset-when-a-new-pool-is-added-into-the-emission-list branch July 29, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkydA AkydA AkydA approved these changes

@notJoon notJoon notJoon approved these changes

@jungju jungju jungju left review comments

@mconcat mconcat Awaiting requested review from mconcat

@jinoosss jinoosss Awaiting requested review from jinoosss

Assignees

@r3v4s r3v4s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r3v4s @jungju @notJoon @AkydA