Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ns1: fix record creation #2115

Merged
merged 2 commits into from
Feb 16, 2024
Merged

ns1: fix record creation #2115

merged 2 commits into from
Feb 16, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 16, 2024

Regression on the API client from a breaking change of the NS1 API client: ns1/ns1-go#220

Same problem as ns1/ns1-go#51

unable to generate a certificate for the domains [*.internal.redacted.com internal.redacted.com internal.redacted.com]:
error: one or more domains had a problem:
[*.internal.redacted.com] [*.internal.redacted.com] acme: error presenting token:
ns1: failed to create record [zone: \"internal.redacted.com\", fqdn: \"_acme-challenge.internal.redacted.com.\"]: PUT https://api.nsone.net/v1/zones/internal.redacted.com/_acme-challenge.internal.redacted.com/TXT: 400 Input validation failed (Value None for field '<obj>.tags' is not of type object)
[internal.redacted.com] [internal.redacted.com] acme: error presenting token:
ns1: failed to create record [zone: \"internal.redacted.com\", fqdn: \"_acme-challenge.internal.redacted.com.\"]: PUT https://api.nsone.net/v1/zones/internal.redacted.com/_acme-challenge.internal.redacted.com/TXT: 400 Input validation failed (Value None for field '<obj>.tags' is not of type object)

Related to:

@ldez ldez added this to the v4.16 milestone Feb 16, 2024
@ldez ldez requested a review from dmke February 16, 2024 17:46
@ldez ldez merged commit 1106ad3 into go-acme:master Feb 16, 2024
7 checks passed
@ldez ldez deleted the fix/ns1-record branch February 16, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants