Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue creating new ns1 record #51

Merged
merged 1 commit into from
Jul 9, 2018
Merged

fix issue creating new ns1 record #51

merged 1 commit into from
Jul 9, 2018

Conversation

mioi
Copy link
Contributor

@mioi mioi commented Jun 29, 2018

after PR #49 was merged, there was an issue creating new records. this should fix it.

The exact error I was seeing, via Terraform (using the latest ns1 terraform provider at master):

1 error(s) occurred:

* ns1_record.rec3: 1 error(s) occurred:

* ns1_record.rec3: PUT https://api.nsone.net/v1/zones/serverless.farm/test3.serverless.farm/A: 400 Input validation failed (Value None for field '<obj>.filters' is not of type array)

@mioi
fix issue creating new ns1 record
3b0a29c 
after PR ns1#49 was merged, there was an issue creating new records.
this should fix it.
alistanis
alistanis approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@alistanis alistanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't realize our API didn't like "filters": null. Good catch!

@alistanis alistanis merged commit 85a531e into ns1:v2 Jul 9, 2018
@mioi mioi deleted the small_bug_20180629 branch July 9, 2018 18:51
@mioi mioi mentioned this pull request Jul 9, 2018
Merged
@ldez ldez mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistanis alistanis alistanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mioi @alistanis