removing omitempty by customer request #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcelda
approved these changes
Jun 12, 2018
pashap
approved these changes
Jun 12, 2018
larsx2
reviewed
Jun 12, 2018
|
@fcelda Yeah, interestingly when you're writing a function to test a method on a type, underscores are the idiomatic way of doing that. Travis recently updated their tests to fail example/test code that doesn't match identifiers consistent with that. @larsx2 In regard to omitempty, customers want to be able to remove filters, and to do that with the api, we need to send |
mioi
added a commit
to mioi/ns1-go
that referenced
this pull request
Jun 29, 2018
after PR ns1#49 was merged, there was an issue creating new records. this should fix it.
mioi
added a commit
to mioi/ns1-go
that referenced
this pull request
Jun 29, 2018
after PR ns1#49 was merged, there was an issue creating new records. this should fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By customer request, we're removing omitempty so that customers can remove filters applied to a record by sending either [] or null - @jamorency
Implications are that if customers want to update a record, they must always send the full set of filters, or they will not be applied. We've spoken about other possible breaking changes and have decided that this is still worth pursuing.