Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an interface for the reporter #76

Open
wants to merge 7 commits into
base: v1
Choose a base branch
from
Open

Added an interface for the reporter #76

wants to merge 7 commits into from

Conversation

come-maiz
Copy link
Contributor

No description provided.

@come-maiz
Copy link
Contributor Author

In order to define a clean interface we first need to clean some things.
The suiteRunner gets the stream flag from the outputWriter. That's fixed in #71.
The Stream and Verbose flags are two different levels of the same thing. Fixed in #72.
The logger is handling part of the output. That's fixed in #75.
Finally, this PR defines the testReporter interface.

@come-maiz come-maiz mentioned this pull request Jan 29, 2016
Closed
fgimenez and others added 4 commits May 26, 2016 15:30
@fgimenez
update imports; make unit tests pass; add travis config
0e15685
@fgimenez
removed unused go packages
93eb158
@come-maiz
Merge pull request #6 from fgimenez/unit-tests
4dc4e50 
update imports; make unit tests pass; add travis config
@come-maiz
Copy the Stream config to the suiteRunner (#2)
937a5a0 
If the runner needs the Stream value from the config, it should not get
it from the reporter. It is better to keep a copy of the value in the
runner itself to make the communication between runner and reporter only
one-direction.
@come-maiz
Join the Stream and Verbose flags into verbosity (#3)
4dee14e
@come-maiz
Split the logger and the reporter (#4)
55f12ba 
The logger and the reporter should be configured independently.
We can do many improvements in the logger, but for now this change
preserves the public interfaces, keeps all the tests passing and
lets us focus on improving the reporter first.
@come-maiz
Added an interface for the reporter
8b4d3d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@come-maiz @fgimenez