-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an interface for the reporter #76
Open
come-maiz
wants to merge
7
commits into
go-check:v1
Choose a base branch
from
come-maiz:reporter_interface2
base: v1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on May 26, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 0e15685 - Browse repository at this point
Copy the full SHA 0e15685View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93eb158 - Browse repository at this point
Copy the full SHA 93eb158View commit details -
Merge pull request #6 from fgimenez/unit-tests
update imports; make unit tests pass; add travis config
Configuration menu - View commit details
-
Copy full SHA for 4dc4e50 - Browse repository at this point
Copy the full SHA 4dc4e50View commit details -
Copy the Stream config to the suiteRunner (#2)
If the runner needs the Stream value from the config, it should not get it from the reporter. It is better to keep a copy of the value in the runner itself to make the communication between runner and reporter only one-direction.
Configuration menu - View commit details
-
Copy full SHA for 937a5a0 - Browse repository at this point
Copy the full SHA 937a5a0View commit details
Commits on May 27, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 4dee14e - Browse repository at this point
Copy the full SHA 4dee14eView commit details -
Split the logger and the reporter (#4)
The logger and the reporter should be configured independently. We can do many improvements in the logger, but for now this change preserves the public interfaces, keeps all the tests passing and lets us focus on improving the reporter first.
Configuration menu - View commit details
-
Copy full SHA for 55f12ba - Browse repository at this point
Copy the full SHA 55f12baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b4d3d9 - Browse repository at this point
Copy the full SHA 8b4d3d9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.