-
-
Notifications
You must be signed in to change notification settings - Fork 980
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Replace wildcards correctly in RoutePattern (#515)
- Loading branch information
1 parent
5704d7e
commit e7728c6
Showing
2 changed files
with
89 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
package chi | ||
|
||
import "testing" | ||
|
||
// TestRoutePattern tests correct in-the-middle wildcard removals. | ||
// If user organizes a router like this: | ||
// | ||
// (router.go) | ||
// r.Route("/v1", func(r chi.Router) { | ||
// r.Mount("/resources", resourcesController{}.Router()) | ||
// } | ||
// | ||
// (resources_controller.go) | ||
// r.Route("/", func(r chi.Router) { | ||
// r.Get("/{resource_id}", getResource()) | ||
// other routes... | ||
// } | ||
// | ||
// This test checks how the route pattern is calculated | ||
// "/v1/resources/{resource_id}" (right) | ||
// "/v1/resources/*/{resource_id}" (wrong) | ||
func TestRoutePattern(t *testing.T) { | ||
routePatterns := []string{ | ||
"/v1/*", | ||
"/resources/*", | ||
"/{resource_id}", | ||
} | ||
|
||
x := &Context{ | ||
RoutePatterns: routePatterns, | ||
} | ||
|
||
if p := x.RoutePattern(); p != "/v1/resources/{resource_id}" { | ||
t.Fatal("unexpected route pattern: " + p) | ||
} | ||
|
||
x.RoutePatterns = []string{ | ||
"/v1/*", | ||
"/resources/*", | ||
// Additional wildcard, depending on the router structure of the user | ||
"/*", | ||
"/{resource_id}", | ||
} | ||
|
||
// Correctly removes in-the-middle wildcards instead of "/v1/resources/*/{resource_id}" | ||
if p := x.RoutePattern(); p != "/v1/resources/{resource_id}" { | ||
t.Fatal("unexpected route pattern: " + p) | ||
} | ||
|
||
x.RoutePatterns = []string{ | ||
"/v1/*", | ||
"/resources/*", | ||
// Even with many wildcards | ||
"/*", | ||
"/*", | ||
"/*", | ||
"/{resource_id}/*", // Keeping trailing wildcard | ||
} | ||
|
||
// Correctly removes in-the-middle wildcards instead of "/v1/resources/*/*/{resource_id}/*" | ||
if p := x.RoutePattern(); p != "/v1/resources/{resource_id}/*" { | ||
t.Fatal("unexpected route pattern: " + p) | ||
} | ||
|
||
x.RoutePatterns = []string{ | ||
"/v1/*", | ||
"/resources/*", | ||
// And respects asterisks as part of the paths | ||
"/*special_path/*", | ||
"/with_asterisks*/*", | ||
"/{resource_id}", | ||
} | ||
|
||
// Correctly removes in-the-middle wildcards instead of "/v1/resourcesspecial_path/with_asterisks{resource_id}" | ||
if p := x.RoutePattern(); p != "/v1/resources/*special_path/with_asterisks*/{resource_id}" { | ||
t.Fatal("unexpected route pattern: " + p) | ||
} | ||
} |