Replace wildcards correctly in RoutePattern #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case there are many /*/ next to each other, this PR Replaces all occurrences leaving the RoutePattern w/out any wildcard.
unmultimedio
force-pushed
the
wildcard-replace-fix
branch
from
9169fff
to
dd96695
Compare
|
Thanks, @pkieltyka for taking a look at this. I forgot to explain in the description, this is a backwards-incompatible On another topic, when can we expect a new release with this change? |
|
@unmultimedio I'll prepare a release for you in a few minutes. I'd consider this a fix, so I'm inclined to make this a tiny release at 4.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there are many
/*/next to each other, this PRReplaces all occurrences leaving the RoutePattern w/out
any wildcard.