Apply config substitute-path to break and trace

[hyangah]

Currently config substitute-path rule applies only to source code retrieval, but does not apply to break and trace.

delve/pkg/config/config.go

Lines 231 to 232 in 71a460f

	# Note that substitution rules will not be used for paths passed to "break" and "trace"
	# commands.

When users opt into use config substitute-path, they need to interact with the source code in different location and absolute file paths. They often incorrectly assume the rule would apply to other commands. Please consider expanding the scope of path substitution.

Also, I noticed that the list or source code visualization uses the substitute path only to retrieve the source code. It keeps using the original path in display. If this feature request is accepted, changing that with the substituted path will be desirable for consistency.

(dlv) config substitute-path /dir/a /dir/b
(dlv) b /dir/a/main.go:9
Breakpoint 1 set at 0x106cedf for main.main() /dir/a/main.go:9
(dlv) c
1
> main.main() /dir/a/main.go:9 (hits goroutine(1):1 total:1) (PC: 0x106cedf)
     4:	
     5:	var a = 1
     6:	
     7:	func main() {
     8:		println(a)
=>   9:		a++
    10:		
 ...

[aarzilli]

This isn't a simple change, the argument of break (and trace) is not a filepath, it's a location expression that's interpreted on the backend-side of delve, whereas substitutions are currently applied by the frontend.

[hyangah]

It would be nice if users can choose this to be applied to backends - e.g. rpc methods like CreateBreakpoint that take Breakpoint with the file name as the input, and the dap implementation. cc @polinasok

[aarzilli]

Implemented by db93049