service,terminal: apply substitute path to trace/break argument #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarzilli
force-pushed
the
substpath
branch
2 times, most recently
from
3b0e7f6 to
58798a4
Compare
derekparker
reviewed
Nov 9, 2020
pkg/locspec/locations.go
Outdated
| @@ -434,6 +438,30 @@ func (loc *NormalLocationSpec) Find(t *proc.Target, processArgs []string, scope | |||
| return []api.Location{addressesToLocation(addrs)}, nil | |||
| } | |||
|
|
|||
| func substitutePath(path string, rules [][2]string) string { | |||
There was a problem hiding this comment.
I'm not a big fan of duplicating this from the terminal package. What are your thoughts on moving this logic here instead and exporting it such that the frontend can use it as well?
Change FindLocation to apply substitute path rules to location expressions. Changes terminal to always print paths after applying substitutions. Implements go-delve#2203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change FindLocation to apply substitute path rules to location
expressions. Changes terminal to always print paths after applying
substitutions.
Implements #2203