<feature>(IS): Use original errors.Is as final test for Is function #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Fix proposition for #25 |
ConradIrwin
reviewed
May 29, 2020
Contributor
ConradIrwin
left a comment
ConradIrwin
left a comment
There was a problem hiding this comment.
Thanks for the quick fix, two small improvements, then we're ready to go.
.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| .idea No newline at end of file | |||
Contributor
There was a problem hiding this comment.
nit: please remove this extra file.
| func Is(e error, original error) bool { | ||
|
|
||
| if e == original { | ||
| if baseErrors.Is(e, original) { |
Contributor
There was a problem hiding this comment.
N.B. This will only compile on go1.13 and above – given that go only supports the two most recent major releases, I think that it's ok for us to drop go1.12 support; but we should add something to the README to let people know that this has happened.
Could you please add a section
## Changelog
* v1.1.0 updated to use go1.13's standard-library errors.Is method instead of == in errors.Is
issue: Current is does not support custom Is definition on underlying errors fix proposition: delegate the error check to standard errors.Is checker so it does have expected behaviour on wrapped errors as well as custom Is implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: Current is does not support custom Is definition on underlying errors
fix proposition: delegate the error check to standard errors.Is checker
so it does have expected behaviour on wrapped errors as well as custom
Is implementation