Last commit broke the project

[dsoprea]

Your code isn't currently compiling. The tests are reflecting this. Looks like the last change broke it.

https://travis-ci.org/github/go-errors/errors/jobs/692460222

baa9282#diff-faeee970b41138d8bdc51e7aa3601141R147

You probably meant Is(), not errors.Is().

Please fix or revert.

[dsoprea]

Incidentally, it looks like you aren't running the unit-tests on pull-requests. Otherwise, that could've allowed you to identify this issue before merging.

#26

[ConradIrwin]

Thanks for reporting @dsoprea, it looks like the tests are running go1.10 which has been unsupported for a while now.

We introduced a fix that only works on go1.13 (the oldest maintained version of go) and above; what version of go are you running?

@titouanfreville I think it should be easy to make your change backward compatible by using go build tags to conditionally change the implementation of Is depending on the go version, or by copy-pasting the code from go1.13's errors package into here. Is that something you'll have time to look at?

[dsoprea]

I hadn't realized that several of my projects weren't recognized as modulized in Travis. So, I was running against your master tip. I forced module support, disabled 1.10 and 1.11, and got unblocked. I would encourage you to revert immediately as your project is currently unusable for first-time implementers. Put the current version in a branch for them to fix. Once fixed, squash and rebase back to master.

…

On Mon, Jun 1, 2020, 13:00 Conrad Irwin ***@***.***> wrote: Thanks for reporting @dsoprea <https://github.com/dsoprea>, it looks like the tests are running go1.10 which has been unsupported for a while now. We introduced a fix that only works on go1.13 (the oldest maintained version of go) and above; what version of go are you running? @titouanfreville <https://github.com/titouanfreville> I think it should be easy to make your change backward compatible by using go build tags to conditionally change the implementation of Is depending on the go version, or by copy-pasting the code from go1.13's errors package into here. Is that something you'll have time to look at? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFOW2SVWR4RWHTXELIMYRDRUPNBXANCNFSM4NPPC5PQ> .

[titouanfreville]

Implemented solution with tags. Test are now ok.
Would be nice to have a lock on PR when travis fails.