Skip to content

<fix>(Backward comp): Add build tags to make errors backward compatible #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2020

Conversation

titouanfreville
Copy link
Collaborator

No description provided.

@titouanfreville
Copy link
Collaborator Author

titouanfreville commented Jun 2, 2020

This should fix #27
How do we run test stack ?
✔️ go1.14 (local)
✔️ go1.10 (travis, https://travis-ci.org/github/go-errors/errors/jobs/693732193)
✔️ go1.8 (travis, https://travis-ci.org/github/go-errors/errors/jobs/693732192)

@titouanfreville titouanfreville linked an issue Jun 2, 2020 that may be closed by this pull request
Copy link
Contributor

@ConradIrwin ConradIrwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwse this looks 💎, thank you.

Do you want to merge to master and tag v1.1.1?


package errors

// Is detects whether the error is equal to a given error. Errors // Is detects whether the error is equal to a given error. Errors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@titouanfreville The comments are doubled for some reason here.

@titouanfreville titouanfreville merged commit 7c02372 into go-errors:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last commit broke the project
2 participants