Migrations: Gitea should not fail just because of no apiConfig return (…

…#13229) (#13273)

* close #13227

* log it

:+1:

Co-authored-by: zeripath <art27@cantab.net>

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>

modules/migrations/gitea_downloader.go

@@ -101,12 +101,13 @@ func NewGiteaDownloader(ctx context.Context, baseURL, repoPath, username, passwo
  // set small maxPerPage since we can only guess
  // (default would be 50 but this can differ)
  maxPerPage := 10
- // new gitea instances can tell us what maximum they have
- if giteaClient.CheckServerVersionConstraint(">=1.13.0") == nil {
- apiConf, _, err := giteaClient.GetGlobalAPISettings()
- if err != nil {
- return nil, err
- }
+ // gitea instances >=1.13 can tell us what maximum they have
+ apiConf, _, err := giteaClient.GetGlobalAPISettings()
+ if err != nil {
+ log.Info("Unable to get global API settings. Ignoring these.")
+ log.Debug("giteaClient.GetGlobalAPISettings. Error: %v", err)
+ }
+ if apiConf != nil {
  maxPerPage = apiConf.MaxResponseItems
  }