Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrations: Gitea should not fail just because of no apiConfig return #13229

Merged
merged 8 commits into from
Oct 22, 2020
Merged

Migrations: Gitea should not fail just because of no apiConfig return #13229

merged 8 commits into from
Oct 22, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 21, 2020

close #13227

@6543 6543 added backport/v1.13 type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 21, 2020
@6543 6543 added this to the 1.14.0 milestone Oct 21, 2020
@6543 6543 mentioned this pull request Oct 21, 2020
Closed
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 21, 2020
6543 and others added 2 commits October 21, 2020 19:25
@6543 @zeripath
log it
62c41cb 
👍

Co-authored-by: zeripath <art27@cantab.net>
@6543
Merge branch 'master' into fix-gitea2gitea_13227
53f034b
@6543
Copy link
Member Author

6543 commented Oct 21, 2020

@zeripath your suggestion is good ... took it ;)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 21, 2020
@codecov-io
Copy link

Codecov Report

Merging #13229 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13229      +/-   ##
==========================================
- Coverage   42.21%   42.20%   -0.01%     
==========================================
  Files         683      683              
  Lines       75457    75458       +1     
==========================================
- Hits        31854    31847       -7     
- Misses      38381    38385       +4     
- Partials     5222     5226       +4
Impacted Files Coverage Δ
modules/migrations/gitea_downloader.go 0.93% <0.00%> (-0.01%) ⬇️
modules/avatar/avatar.go 50.00% <0.00%> (-4.77%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
modules/log/event.go 58.96% <0.00%> (-0.95%) ⬇️
models/error.go 35.72% <0.00%> (-0.51%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️
services/pull/check.go 52.55% <0.00%> (+1.45%) ⬆️
services/pull/patch.go 55.68% <0.00%> (+1.70%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819901b...0ddfbc1. Read the comment docs.

@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 81d3942 into go-gitea:master Oct 22, 2020
@techknowlogick
Copy link
Member

please send backport :)

@6543 6543 deleted the fix-gitea2gitea_13227 branch October 22, 2020 09:49
6543 added a commit to 6543-forks/gitea that referenced this pull request Oct 23, 2020
@6543 @zeripath @techknowlogick
Migrations: Gitea should not fail just because of no apiConfig return (…
afe1cf6 
…go-gitea#13229)

* close go-gitea#13227

* log it

:+1:

Co-authored-by: zeripath <art27@cantab.net>

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@6543 6543 mentioned this pull request Oct 23, 2020
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Oct 23, 2020
@6543
Copy link
Member Author

6543 commented Oct 23, 2020

Backport: #13273

lunny pushed a commit that referenced this pull request Oct 23, 2020
@6543 @zeripath @techknowlogick
Migrations: Gitea should not fail just because of no apiConfig return (…
39412c6 
…#13229) (#13273)

* close #13227

* log it

:+1:

Co-authored-by: zeripath <art27@cantab.net>

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks left review comments

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Migrate From Gitea not working for me
7 participants
@6543 @codecov-io @techknowlogick @lunny @lafriks @zeripath @GiteaBot