-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite docker stuff #104
Comments
keep s6 as an init replacement. |
rewrite env variables |
dockerfile cleanup |
I would suggest to have the smaller image as possible and by doing so, the compilation should be done outside and the binary pushed to the docker (maybe from scratch instead alpine). I could provide later a link to a docker images that can be used to build Go program and make docker images without compiler program. Edit 11/10/16: |
@DblK feel free to update your comment with the appropriate link :) |
We will use drone to build the binary outside of the docker image, the drone pipeline is in preparation ;) |
why do we need that s6 stuff instead of setting things up in the dockerfile? |
@willemvd we need s6 as process manager because we will run more than a single service within the container, at least we need Gitea and openSSH. |
I would strongly recommend against using |
The way you say it makes it sound like avoiding shell scripts is a bad thing |
Yes, it breaks many things. Including git-hooks and https://github.com/go-gitea/git. |
Nobody wants to use scratch, alpine is a perfect base |
Using scratch as base not is (in this case) a good idea cause you need OpenSSH and shell scripts. |
We already refactored docker |
Issue 85: Make a page to list all tags
* set default command execution timeout as changable * fix lint
as gitea grows, we have to rewrite docker stuff in the docker dir.
this issue will stays open until PR is merged and will serve a repo for comments.
feel free to add what you think should be done regarding docker build
The text was updated successfully, but these errors were encountered: