Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite docker stuff #104

Closed
xinity opened this issue Nov 7, 2016 · 16 comments
Closed

rewrite docker stuff #104

xinity opened this issue Nov 7, 2016 · 16 comments
Assignees
Labels
pr/wip This PR is not ready for review type/enhancement An improvement of existing functionality
Milestone

Comments

@xinity
Copy link
Contributor

xinity commented Nov 7, 2016

as gitea grows, we have to rewrite docker stuff in the docker dir.

this issue will stays open until PR is merged and will serve a repo for comments.

feel free to add what you think should be done regarding docker build

@xinity xinity added the type/enhancement An improvement of existing functionality label Nov 7, 2016
@xinity xinity added this to the 1.0.0 milestone Nov 7, 2016
@xinity xinity self-assigned this Nov 7, 2016
@xinity
Copy link
Contributor Author

xinity commented Nov 7, 2016

keep s6 as an init replacement.

@xinity
Copy link
Contributor Author

xinity commented Nov 7, 2016

rewrite env variables

@xinity
Copy link
Contributor Author

xinity commented Nov 7, 2016

dockerfile cleanup

@xinity xinity added the pr/wip This PR is not ready for review label Nov 7, 2016
@DblK
Copy link
Member

DblK commented Nov 7, 2016

I would suggest to have the smaller image as possible and by doing so, the compilation should be done outside and the binary pushed to the docker (maybe from scratch instead alpine).

I could provide later a link to a docker images that can be used to build Go program and make docker images without compiler program.

Edit 11/10/16:
Here is the link to build dockerfile for Go program with image "SCRATCH"

@xinity
Copy link
Contributor Author

xinity commented Nov 7, 2016

@DblK feel free to update your comment with the appropriate link :)

@tboerger
Copy link
Member

tboerger commented Nov 7, 2016

We will use drone to build the binary outside of the docker image, the drone pipeline is in preparation ;)

@xinity
Copy link
Contributor Author

xinity commented Nov 7, 2016

@tboerger nice !

then @DblK send the link to me :) i'd be happy to learn moaaarrrr go :)

@willemvd
Copy link
Contributor

willemvd commented Nov 8, 2016

why do we need that s6 stuff instead of setting things up in the dockerfile?

@tboerger
Copy link
Member

tboerger commented Nov 9, 2016

@willemvd we need s6 as process manager because we will run more than a single service within the container, at least we need Gitea and openSSH.

@ghost
Copy link

ghost commented Nov 11, 2016

I would strongly recommend against using scratch as that renders any form of shell scripting invalid.

@ptman
Copy link
Contributor

ptman commented Nov 11, 2016

The way you say it makes it sound like avoiding shell scripts is a bad thing

@ghost
Copy link

ghost commented Nov 11, 2016

Yes, it breaks many things. Including git-hooks and https://github.com/go-gitea/git.

@tboerger
Copy link
Member

Nobody wants to use scratch, alpine is a perfect base

@ghost
Copy link

ghost commented Nov 11, 2016

@tboerger, I just wanted to let anyone that likes @DblK's idea know that it's not going to be good if we use scratch as base.

@ogarcia
Copy link
Contributor

ogarcia commented Nov 14, 2016

Using scratch as base not is (in this case) a good idea cause you need OpenSSH and shell scripts.

@tboerger
Copy link
Member

tboerger commented Dec 3, 2016

We already refactored docker

@tboerger tboerger closed this as completed Dec 3, 2016
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this issue Jan 5, 2017
lunny added a commit to lunny/gitea that referenced this issue Feb 7, 2019
* set default command execution timeout as changable

* fix lint
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr/wip This PR is not ready for review type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

6 participants