-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor dependencies and add Makefile & Dockerfile #6
Conversation
* Don't log.Fatal if there's no .env, there won't be a .env if you run with ENV variables * Make the DSN multiline so it's easier to read
Hey @metalmatze, This looks awesome. Please allow me a few days to get familiar with the changes but from the first look, I absolutely love what you did here. :) I'm in Africa right now where internet is paid by the megabyte so I can't pull this in yet, but will be able to next week. Have a great 2nd day of Christmas and year's end! |
Consider using travis-ci to build minimal scratch images instead of using alpine as base, example can be seen here. |
@metalmatze How are you handling database migrations in your Docker build? Right now I see that the @zet4 There'll definitely be releases but Ana is in a pretty sad (unstable) state right now. I expect things to stabilize in a few months. |
Please stick with alpine as base image. Scratch is just way to less. We should probably use travis as CI for this project. Unless you have a server to host drone on, which would result in much faster build times. If there's something I'd be happy to help to set it up. I just had an instance and went with it. Regarding |
I don't see how gitea's conversation has any relevancy to ana, gitea needs alpine as base because it needs shell scripting capabilities for hooks and whatnot, no such thing exists in ana and I don't think there will be need for such either? |
Hey. I want to run Ana in docker on my machines. I made a few changes to be able to run Ana inside docker:
make
builds a binary./ana
make clean
removes./ana
andana
from$GOPATH/bin
make fmt
runsgo fmt
on the projectmake vet
runsgo vet
on the projectmake errcheck
runsgo errcheck
on the project and downloads errcheck if not in $PATHmake lint
runsgolint
on the project and downloads golint if not in $PATHmake test
runsgo test
in every Go package and creates acoverage.out
for code coverage e.g. with coverall or codecovmake install
creates a static binary in$GOPATH/bin
make build
creates a static binary./ana
make docker
creates a docker images, currently in my own namespace, you should create an organization for this project 😊log.Fatal
if there's no.env
because I want to inject config variables via env from outside the docker container and there won't be an.env
If you have any question left please ask. I just put everything inside this one big PR. I can also split stuff apart.
EDIT: Should I update the PR with changes to README.md or put into another PR?