Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code-view active class being applied to PR code comment editor #13010

Closed
mrsdizzie opened this issue Oct 2, 2020 · 1 comment · Fixed by #13011
Closed

code-view active class being applied to PR code comment editor #13010

mrsdizzie opened this issue Oct 2, 2020 · 1 comment · Fixed by #13011
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.13.0

Comments

@mrsdizzie
Copy link
Member

What should be the styling for selected lines of code in file view (I think?) is also affecting the code editor because it ends up with the same class structure of .code-view .active

Screen Shot 2020-10-01 at 11 14 18 PM
@mrsdizzie mrsdizzie added type/bug topic/ui Change the appearance of the Gitea UI labels Oct 2, 2020
@mrsdizzie mrsdizzie added this to the 1.13.0 milestone Oct 2, 2020
@mrsdizzie
Copy link
Member Author

Would be nice while fixing this to also fix what ever is causing everything comment/editor related to be monospaced -- assume general issue is that the comments/editor don't actually belong in code-view class

mrsdizzie added a commit to mrsdizzie/gitea that referenced this issue Oct 2, 2020
@mrsdizzie
Remove code-view class from diff view
dad86fc 
code-view class seems unecessary here as everything needed style wise comes from various diff classes. This allows comments and comment editor to be styled properly and fixes linked bug.

Fixes go-gitea#13010
@mrsdizzie mrsdizzie mentioned this issue Oct 2, 2020
Merged
techknowlogick added a commit that referenced this issue Oct 2, 2020
@mrsdizzie @zeripath @techknowlogick
Remove code-view class from diff view (#13011)
7a34fc0 
code-view class seems unecessary here as everything needed style wise comes from various diff classes. This allows comments and comment editor to be styled properly and fixes linked bug.

Fixes #13010

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

Remove code-view class from diff view mrsdizzie/gitea
1 participant
@mrsdizzie