Remove code-view class from diff view #13011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-view class seems unecessary here as everything needed style wise comes from various diff classes. This allows comments and comment editor to be styled properly and fixes linked bug. Fixes go-gitea#13010
Codecov Report
@@ Coverage Diff @@
## master #13011 +/- ##
=======================================
Coverage 42.59% 42.60%
=======================================
Files 671 671
Lines 73635 73635
=======================================
+ Hits 31365 31372 +7
+ Misses 37184 37181 -3
+ Partials 5086 5082 -4
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
zeripath
approved these changes
Oct 2, 2020
GiteaBot
added
lgtm/need 1
CirnoT
approved these changes
Oct 2, 2020
GiteaBot
added
lgtm/done
bagasme
reviewed
Oct 2, 2020
| @@ -997,6 +997,7 @@ i.icon.centerlock { | |||
| color: rgba(27, 31, 35, .3); | |||
| width: 1%; | |||
| user-select: none; | |||
| font-family: @monospaced-fonts, monospace; | |||
SimpleMDE seems to use monospace font in all instances (which I don't really like either). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code-view class seems unecessary here as everything needed style wise comes from various diff classes. This allows comments and comment editor to be styled properly and fixes linked bug.
Fixes #13010
Before:
After:
