Skip to content

Markdown checkboxes rendered badly #17395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
noerw opened this issue Oct 21, 2021 · 2 comments · Fixed by #17411
Closed

Markdown checkboxes rendered badly #17395

noerw opened this issue Oct 21, 2021 · 2 comments · Fixed by #17411
Labels
outdated/theme/markdown type/bug
Milestone
1.15.6

Comments

@noerw
Copy link
Member

noerw commented Oct 21, 2021 •
edited
Loading

Gitea Version

1.15.4 + 58cd55d (recent 1.16)

Git Version

No response

Operating System

No response

How are you running Gitea?

gitea.com

Database

No response

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Description

Spaced lists render badly, see screenshot.

Reproducer:

#### dense list
- [ ] foo
- [ ] barbarbarbarbarbarbarbar barbarbarbarbarbarbarbar barbarbarbarbarbarbarbar barbarbarbarbarbarbar barbarbarbarbar
- [ ] baz

#### not so dense list
- [ ] foo

- [ ] barbarbarbarbarbarbarbar barbarbarbarbarbarbarbar barbarbarbarbarbarbarbar barbarbarbarbarbarbar barbarbarbarbar

- [ ] baz

Screenshots

image
@noerw noerw added this to the 1.15.6 milestone Oct 21, 2021
@silverwind
Copy link
Member

GH rendering for comparison:

dense list

  • foo
  • barbarbarbarbarbarbarbar barbarbarbarbarbarbarbar barbarbarbarbarbarbarbar barbarbarbarbarbarbar barbarbarbarbar
  • baz

not so dense list

  • foo

  • barbarbarbarbarbarbarbar barbarbarbarbarbarbarbar barbarbarbarbarbarbarbar barbarbarbarbarbarbar barbarbarbarbar

  • baz

Sorry, something went wrong.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Oct 23, 2021 •
edited
Loading

It can be fixed by this patch.

.markup .task-list-item {
    list-style-type: none;
    position: relative; /* add this */
}
.markup .task-list-item input[type=checkbox] {
   /* before:  margin: 0 6px 0.25em -1.6em;
      replace with below:
  */
    position: absolute;
    top: 0.25em;
    left: -1.6em;
}

image

@wxiaoguang wxiaoguang linked a pull request Oct 23, 2021 that will close this issue
Fix issue content history problems, improve UI #17404
Merged
@wxiaoguang wxiaoguang mentioned this issue Oct 23, 2021
Merged
wxiaoguang added a commit to wxiaoguang/gitea that referenced this issue Oct 23, 2021
@wxiaoguang
Fix issue markdown bugs
1c4f239 
* Bug fix: render Markdown http://AppURL/org/repo/issues/4?a=1&b=2#comment-123 test to HTML correctly, close go-gitea#17394
* Bug fix: fix the positions of checkboxes in rendered HTML, close go-gitea#17395
@wxiaoguang wxiaoguang mentioned this issue Oct 23, 2021
Merged
@wxiaoguang wxiaoguang removed a link to a pull request Oct 23, 2021
Fix issue content history problems, improve UI #17404
Merged
wxiaoguang added a commit that referenced this issue Oct 23, 2021
@wxiaoguang
Fix issue markdown bugs (#17411)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6c49517 
* Bug fix: render Markdown http://AppURL/org/repo/issues/4?a=1&b=2#comment-123 test to HTML correctly, close #17394
* Bug fix: fix the positions of checkboxes in rendered HTML, close #17395
wxiaoguang added a commit to wxiaoguang/gitea that referenced this issue Oct 23, 2021
@wxiaoguang
Fix issue markdown bugs
00cf7e5 
* Bug fix: render Markdown `http://AppURL/org/repo/issues/4?a=1&b=2#comment-123 test` to HTML correctly, close go-gitea#17394
* Bug fix: fix the positions of checkboxes in rendered HTML, close go-gitea#17395

# Conflicts:
#	modules/markup/html.go
@wxiaoguang wxiaoguang mentioned this issue Oct 23, 2021
Merged
lunny pushed a commit that referenced this issue Oct 23, 2021
@wxiaoguang
Fix issue markdown bugs (#17413)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
175ebc6 
* Bug fix: render Markdown `http://AppURL/org/repo/issues/4?a=1&b=2#comment-123 test` to HTML correctly, close #17394
* Bug fix: fix the positions of checkboxes in rendered HTML, close #17395

# Conflicts:
#	modules/markup/html.go
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@wxiaoguang
Fix issue markdown bugs (go-gitea#17411)
7826f94 
* Bug fix: render Markdown http://AppURL/org/repo/issues/4?a=1&b=2#comment-123 test to HTML correctly, close go-gitea#17394
* Bug fix: fix the positions of checkboxes in rendered HTML, close go-gitea#17395
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated/theme/markdown type/bug
Projects
None yet
Milestone
1.15.6
Development

Successfully merging a pull request may close this issue.

Fix issue markdown bugs wxiaoguang/gitea
3 participants
@silverwind @wxiaoguang @noerw