Backport: fix issue markdown bugs #17413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bug fix: render Markdown `http://AppURL/org/repo/issues/4?a=1&b=2#comment-123 test` to HTML correctly, close go-gitea#17394 * Bug fix: fix the positions of checkboxes in rendered HTML, close go-gitea#17395 # Conflicts: # modules/markup/html.go
delvh
approved these changes
Oct 23, 2021
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Oct 23, 2021
GiteaBot
added
lgtm/done
wxiaoguang
added a commit
that referenced
this pull request
Oct 25, 2021
We allow to render empty check list item - [ ], while GitHub doesn't allow. To make the rendering correct, we need tune the UI (the last PR #17413 uses absolute layout, which makes the empty checkbox item can not be displayed correctly)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue markdown bugs, backport #17411
http://AppURL/org/repo/issues/4?a=1&b=2#comment-123 testto HTML correctly, close Issue comment URLs parsed / emitted incorrectly #17394