Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actions runner last online var adressed incorrectly #25336

Closed
derelm opened this issue Jun 18, 2023 · 0 comments
Closed

actions runner last online var adressed incorrectly #25336

derelm opened this issue Jun 18, 2023 · 0 comments
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@derelm
Copy link
Contributor

derelm commented Jun 18, 2023 •
edited
Loading

Description

When editing an action runner, its Last Online state is always "never" because the respective variable is addressed incorrectly in templates/shared/actions/runner_edit.tmpl Line 16

A fix was already applied to main as part of commit 8228751c55d6a4263f0fec2932ca16181c09c97d but has not been backported.
PR: #24806.

This issue is just about L16 of the cited commit and file - i cannot judge the other changes in that commit.

Screenshots

grafik

Screenshot taken on german localized instance - Niemals= never in english.
As can be seen the runner is currently connected so it should read "now" instead.

Gitea Version

1.20.0-rc0

Can you reproduce the bug on the Gitea demo site?

No

Operating System

No response

Browser Version

Firefox 114.0.1
@derelm derelm added type/bug topic/ui Change the appearance of the Gitea UI labels Jun 18, 2023
@derelm derelm mentioned this issue Jun 18, 2023
Merged
lunny pushed a commit that referenced this issue Jun 18, 2023
@derelm
Fix action runner last online state on edit page (#25337)
0543159 
Backport fix for action runner last online state not showing in
`release/v1.20` - fixes #25336
@derelm derelm closed this as completed Jun 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@derelm