Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action runner last online state on edit page #25337

Merged
merged 3 commits into from
Jun 18, 2023

Conversation

derelm
Copy link
Contributor

@derelm derelm commented Jun 18, 2023

Backport fix for action runner last online state not showing in release/v1.20 - fixes #25336

Fix var adressed in the wrong way
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 18, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone Jun 18, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2023
@derelm derelm changed the title Update runner_edit.tmpl Fix action runner last online state on edit page Jun 18, 2023
@silverwind
Copy link
Member

Is it not needed on main branch? Which PR did fix it there?

@derelm
Copy link
Contributor Author

derelm commented Jun 18, 2023

main had this PR: #24806

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 18, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 18, 2023
@lunny lunny enabled auto-merge (squash) June 18, 2023 10:05
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 18, 2023
@lunny lunny merged commit 0543159 into go-gitea:release/v1.20 Jun 18, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 18, 2023
@derelm derelm deleted the fix-admin-actions-lastonline branch June 18, 2023 14:16
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants