Skip to content

Webhook demilestoned contains milestone #32887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kim2048 opened this issue Dec 18, 2024 · 1 comment · Fixed by #32923
Closed

Webhook demilestoned contains milestone #32887

kim2048 opened this issue Dec 18, 2024 · 1 comment · Fixed by #32923
Labels
type/bug

Comments

@kim2048
Copy link

kim2048 commented Dec 18, 2024

Description

Hello, when I receive the webhook action "demilestoned", the "issue.milestone" field is still set to the last milestone data. I'm not sure if this is a feature, but I thought the issue data I get in a webhook is always set to the current state (after the action happend) of the issue.

Gitea Version

1.22.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Don't know, I'm only a small user ;)

Database

None
@lunny lunny mentioned this issue Dec 20, 2024
Merged
lunny added a commit that referenced this issue Dec 25, 2024
@lunny
demilestone should not include milestone (#32923)
f44712f 
Fix #32887
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Dec 25, 2024
@lunny @GiteaBot
demilestone should not include milestone (go-gitea#32923)
8635cc7 
Fix go-gitea#32887
@GiteaBot GiteaBot mentioned this issue Dec 25, 2024
Merged
lunny added a commit that referenced this issue Dec 25, 2024
@GiteaBot @lunny
demilestone should not include milestone (#32923) (#32979)
ad1b765 
Backport #32923 by @lunny

Fix #32887

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@kim2048
Copy link
Author

kim2048 commented Jan 6, 2025

Thank you :)

project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
@lunny
demilestone should not include milestone (go-gitea#32923)
2bcbfbc 
Fix go-gitea#32887

(cherry picked from commit f44712f)

Conflicts:
	services/issue/milestone_test.go
  trivial conflicts (require vs assert)
(cherry picked from commit 2ffa9a5)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

demilestone should not include milestone lunny/gitea
1 participant
@kim2048