Skip to content

demilestone should not include milestone #32923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 25, 2024
Merged

demilestone should not include milestone #32923

merged 4 commits into from
Dec 25, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 20, 2024

Fix #32887

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 20, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 20, 2024
@lunny lunny added type/bug backport/v1.23 This PR should be backported to Gitea 1.23 and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XS modifies/go Pull requests that update Go code labels Dec 20, 2024
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 24, 2024
wxiaoguang
wxiaoguang approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to have a test

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 25, 2024
@lunny
Copy link
Member Author

lunny commented Dec 25, 2024

Better to have a test

Test added.

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 25, 2024
@lunny lunny enabled auto-merge (squash) December 25, 2024 05:12
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 25, 2024
@lunny lunny merged commit f44712f into go-gitea:main Dec 25, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 25, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 25, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 25, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7da99b0 
* giteaofficial/main:
  demilestone should not include milestone (go-gitea#32923)
  fix textarea newline handle (go-gitea#32966)
  Fix Azure blob object `Seek`  (go-gitea#32974)
  Fix maven pom inheritance (go-gitea#32943)
  Refactor arch route handlers (go-gitea#32972)
  [skip ci] Updated translations via Crowdin
  Refactor tmpl and blob_excerpt (go-gitea#32967)
  Clarify path param naming (go-gitea#32969)
  Refactor getpatch/getdiff functions and remove unnecessary fallback (go-gitea#32817)
  Refactor request context (go-gitea#32956)
@lunny lunny deleted the lunny/fix_demilestoned_webhook branch December 25, 2024 07:14
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 25, 2024
@lunny @GiteaBot
demilestone should not include milestone (go-gitea#32923)
8635cc7 
Fix go-gitea#32887
@GiteaBot GiteaBot mentioned this pull request Dec 25, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Dec 25, 2024
lunny added a commit that referenced this pull request Dec 25, 2024
@GiteaBot @lunny
demilestone should not include milestone (#32923) (#32979)
ad1b765 
Backport #32923 by @lunny

Fix #32887

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this pull request Jan 23, 2025
@lunny
demilestone should not include milestone (go-gitea#32923)
2bcbfbc 
Fix go-gitea#32887

(cherry picked from commit f44712f)

Conflicts:
	services/issue/milestone_test.go
  trivial conflicts (require vs assert)
(cherry picked from commit 2ffa9a5)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Webhook demilestoned contains milestone
4 participants
@lunny @wxiaoguang @hiifong @GiteaBot