Too large webhook's response (>65K response) causes the webhook to be sent indefinitely #3561
Comments
|
|
|
Hi @lunny, initially I thought of changing the column too, but according to https://stackoverflow.com/a/6766854, MEDIUMTEXT allows up to 16Mbits and LONGTEXT up to 64Gbits, which seemed too overkill to me. As the response appears to be used only on the webhook response panel, which by default only shows the last ten webhooks calls, and given that usually the system pinged will have its own logs too, wouldn't it make more sense to trim the response to, something like 60K, f.ex, and then append some text stating that the response has been trimmed? In anycase, we're not doing anything special with that table/columns, so going to MEDIUMTEXT would be ok for us. also, what would happen now when the payload is too big to fit into thanks, |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions. |
|
Hi, in order to avoid the stale bot, anything else needed on this issue? thx, |
techknowlogick
added
issue/confirmed
|
Hi, I'm facing the same issue here with 1.13.0 :-) BR, |
Mysql TEXT has a limit of 64KB, change this to LONGTEXT in mysql only so we can have bigger hook payloads. Postgresql has unlimited TEXT - https://www.postgresql.org/docs/current/datatype-character.html Sqlite has unlimited TEXT - https://www.sqlitetutorial.net/sqlite-data-types/#:~:text=The%20maximum%20length%20of%20TEXT,SQLite%20supports%20various%20character%20encodings. Same issue as #16656 but for hook_task Fixes #10252, #19679, #3561
|
Fixed in #20038 |
Mysql TEXT has a limit of 64KB, change this to LONGTEXT in mysql only so we can have bigger hook payloads. Postgresql has unlimited TEXT - https://www.postgresql.org/docs/current/datatype-character.html Sqlite has unlimited TEXT - https://www.sqlitetutorial.net/sqlite-data-types/#:~:text=The%20maximum%20length%20of%20TEXT,SQLite%20supports%20various%20character%20encodings. Same issue as go-gitea#16656 but for hook_task Fixes go-gitea#10252, go-gitea#19679, go-gitea#3561
Mysql TEXT has a limit of 64KB, change this to LONGTEXT in mysql only so we can have bigger hook payloads. Postgresql has unlimited TEXT - https://www.postgresql.org/docs/current/datatype-character.html Sqlite has unlimited TEXT - https://www.sqlitetutorial.net/sqlite-data-types/#:~:text=The%20maximum%20length%20of%20TEXT,SQLite%20supports%20various%20character%20encodings. Same issue as go-gitea#16656 but for hook_task Fixes go-gitea#10252, go-gitea#19679, go-gitea#3561
[x]):Description
For background see jenkinsci/generic-webhook-trigger-plugin#42, but basically when a webhook's response is too big to not fit into hook_task.response_content (>65K response for MySQL), the webhook is fired, but it doesn't get updated (is_released, is_succeed and released remain at 0. Haven't tried to see what happens when there is too much information too on the request_content or the payload_content (e.g. a push webhook with way too many commits)
The text was updated successfully, but these errors were encountered: